Skip to content

Performance chart: Replace deprecated plotAreaFrame #16145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 19, 2025
Merged

Performance chart: Replace deprecated plotAreaFrame #16145

merged 4 commits into from
Sep 19, 2025
+5 −4

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Sep 18, 2025

Closes WOOMOB-1293

Description

This PR removes the deprecated plotAreaFrame and use the new plotFrame when checking touch area on the performance chart.

Testing steps

  • Log in to a store with existing orders.
  • On the dashboard screen, update the date range on the Performance card to see a non empty revenue chart.
  • Touch on any part of the chart or drag your fingers through the date. Confirm that the stats on the dashboard cards are updated accordingly.

Testing information

Tested with simulator iPhone 17 iOS 26.

Screenshots

Simulator.Screen.Recording.-.iPhone.17.-.2025-09-18.at.15.27.23.mov
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.3 milestone Sep 18, 2025
@itsmeichigo itsmeichigo added the type: task An internally driven task. label Sep 18, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 18, 2025 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 23.3. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@itsmeichigo itsmeichigo marked this pull request as ready for review September 18, 2025 08:33
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 18, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16145-3b7a05d
Version23.2
Bundle IDcom.automattic.alpha.woocommerce
Commit3b7a05d
Installation URL169ap468oo9q8
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

RafaelKayumov
RafaelKayumov approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The chart is responsive and works as expected.

@itsmeichigo itsmeichigo merged commit 03afa52 into trunk Sep 19, 2025
13 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1293-wcios17-store-charts-address-plotareaframe-deprecation branch September 19, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelKayumov RafaelKayumov RafaelKayumov approved these changes

Assignees

No one assigned

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.3

Development

Successfully merging this pull request may close these issues.

5 participants

@itsmeichigo @dangermattic @wpmobilebot @RafaelKayumov